[PATCH] D79552: [YAMLVFSWriter][Tests][NFC] Add couple tests

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 7 10:47:19 PDT 2020


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: ormris.

We should!



================
Comment at: llvm/unittests/Support/VirtualFileSystemTest.cpp:2278
+
+TEST_F(VFSFromYAMLTest, YAMLVFSWriterTestEmbeddedDirs) {
+  ScopedDir TestDirectory("virtual-file-system-test", /*Unique*/ true);
----------------
What's an "embedded dir"? I'm not sure what makes this test different from the existing writer test. Could you add a small comment about what the test is testing?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79552/new/

https://reviews.llvm.org/D79552





More information about the llvm-commits mailing list