[PATCH] D79574: [mlir] Remove unnecessary DEPENDS for MLIRMlirOptMain

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 7 07:20:05 PDT 2020


antiagainst created this revision.
antiagainst added reviewers: mehdi_amini, stephenneuendorffer.
Herald added subscribers: llvm-commits, Kayjukh, frgossen, grosul1, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, shauheen, jpienaar, rriddle, mgorny.
Herald added a project: LLVM.

https://github.com/llvm/llvm-project/commit/c296d2dc53d5c11c
fixes the dependency issue by turning LINK_LIBS to PUBLIC.
These explicit DEPENDS are not needed anymore.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79574

Files:
  mlir/tools/mlir-opt/CMakeLists.txt


Index: mlir/tools/mlir-opt/CMakeLists.txt
===================================================================
--- mlir/tools/mlir-opt/CMakeLists.txt
+++ mlir/tools/mlir-opt/CMakeLists.txt
@@ -41,10 +41,6 @@
 
   LINK_LIBS PUBLIC
   ${LIBS}
-
-  DEPENDS
-  intrinsics_gen
-  mlir-headers
   )
 
 add_llvm_tool(mlir-opt


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79574.262641.patch
Type: text/x-patch
Size: 318 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200507/c589ba9d/attachment.bin>


More information about the llvm-commits mailing list