[PATCH] D79542: [WebAssembly] Disallow 'shared-mem' rather than 'atomics'

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

> This was previously done by disallowing the 'atomics' feature, but that could lead to an awkward situation in which an object was marked as disallowing atomics when it in fact used atomics itself. Once atomic operations are allowed in modules with unshared memory, this would result in modules containing atomics but not having the 'atomics' feature in their target-features sections.

Is this possible now? When we disallow atomics now, haven't we already stripped all atomic instructions by then, or we didn't have atomics in the first place? How can a module contain atomics and disallow it at the same time?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79542/new/

https://reviews.llvm.org/D79542