[PATCH] D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints

[Konstantin Schwarz via Phabricator via llvm-commits]

kschwarz added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp:481
+      Inst.addImm(Flag);
+      for (unsigned i = 0; i < NumRegs; i++) {
+        MIRBuilder.buildCopy(OpInfo.Regs[i], SourceRegs[0]);
----------------
paquette wrote:
> Can you use a range-based for loop here?
I've removed the loop entirely, and return if the number of registers is > 1. In that case we have to unpack the value first, which was missing here. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78319/new/

https://reviews.llvm.org/D78319