[PATCH] D79332: [MLIR] Nested regions test for Buffer Assginment

[Stephan Herhut via Phabricator via llvm-commits]

herhut accepted this revision.
herhut added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: stephenneuendorffer.

Thanks, I am happy to see this land. Just some nits.



================
Comment at: mlir/test/Transforms/buffer-placement.mlir:416
+
+// Test Case: Nested regions - This test defines a GenericOp inside the region of another GenericOp.
+// BufferPlacement Expected Behaviour: The AllocOp of inner GenericOp should remain inside the region of outer GenericOp and it
----------------
Could you reflow the comment to match 80 chars?



================
Comment at: mlir/test/Transforms/buffer-placement.mlir:455
+// CHECK-NEXT:     %{{.*}} = exp
+//      CHECK:  linalg.copy
+// CHECK-NEXT:  dealloc %[[GENERIC1_ALLOC]]
----------------
Could you add where the BB3 starts? That makes it easier to understand what is going on here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79332/new/

https://reviews.llvm.org/D79332