[PATCH] D79517: [MLIR] Rename SideEffects.td -> SideEffectInterfaces.td

[Alex Zinenko via Phabricator via llvm-commits]

ftynse accepted this revision.
ftynse added a comment.

In D79517#2023685 <https://reviews.llvm.org/D79517#2023685>, @stephenneuendorffer wrote:

> The dialect interfaces don't necessary exist in an "Interfaces" path.   (Although perhaps they should?)


I would differentiate between dialect-specific interfaces (e.g., LinalgStructured) and dialect-independent. The former should live with their dialect similarly to other dialect-specific stuff.

Regarding this change, I am always for consistency and since it makes the code base more consistent, I support the change even if we decide to mass-rename everything later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79517/new/

https://reviews.llvm.org/D79517