[PATCH] D79479: [MLIR] Add complex addition and substraction to the standard dialect

Alexander Belyaev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 23:59:35 PDT 2020


pifon2a accepted this revision.
pifon2a added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:221
+
+def AddCOp : ComplexArithmeticOp<"addc"> {
+  let summary = "complex number addition";
----------------
@ftynse Alex, do you know if there is a need for arithmetic ops for complex<integer_type>? If yes, how should we call this one? `AddCFOp`? :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79479/new/

https://reviews.llvm.org/D79479





More information about the llvm-commits mailing list