[PATCH] D78736: [DWARF5]: Added support for dumping strx forms in llvm-dwarfdump

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 22:42:17 PDT 2020


SouraVX updated this revision to Diff 262549.
SouraVX added a comment.

Addressed @ikudrin comments, Thanks for this!

- Replaced `assert`s with error handling and added 2 test cases to test these error creation and dumping.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78736/new/

https://reviews.llvm.org/D78736

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/test/DebugInfo/X86/debug-macinfo-strp.s
  llvm/test/DebugInfo/X86/debug-macinfo-strx.s
  llvm/test/DebugInfo/X86/debug-macro-empty-macro-offset.s
  llvm/test/DebugInfo/X86/debug-macro-empty-str-offset.s
  llvm/test/DebugInfo/X86/debug-macro-multi-cu-strx.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78736.262549.patch
Type: text/x-patch
Size: 16947 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200507/42becd97/attachment.bin>


More information about the llvm-commits mailing list