[PATCH] D79541: [WIP][mlir] RFC - Simplify and better document std.view semantics

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 19:20:15 PDT 2020


nicolasvasilache created this revision.
Herald added subscribers: llvm-commits, Kayjukh, frgossen, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini, jfb.
Herald added a reviewer: ftynse.
Herald added a project: LLVM.

This discussion <https://llvm.discourse.group/t/viewop-isnt-expressive-enough/991/2> raised some concerns with ViewOp.
This revision proposes to simplify the existing semantics and implementation.
This simplification effort is voluntarily restrictive and acts as a stepping stone towards supporting richer semantics: treat the non common cases as YAGNI for now.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79541

Files:
  mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
  mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
  mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp
  mlir/lib/Dialect/StandardOps/IR/Ops.cpp
  mlir/test/Conversion/StandardToLLVM/convert-to-llvmir.mlir
  mlir/test/Dialect/Linalg/affine.mlir
  mlir/test/Dialect/Linalg/loops.mlir
  mlir/test/Dialect/Linalg/roundtrip.mlir
  mlir/test/mlir-cpu-runner/linalg_integration_test.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79541.262526.patch
Type: text/x-patch
Size: 106221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200507/9995acc4/attachment.bin>


More information about the llvm-commits mailing list