[PATCH] D62540: [SampleFDO] For functions without profiles, provide an option to put them in a special text section

[Wenlei He via Phabricator via llvm-commits]

wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

LGTM, thanks.



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:181
+static cl::opt<bool> ProfileUnknownInSpecialSection(
+    "profile-unknown-in-special-section", cl::Hidden, cl::init(false),
+    cl::ZeroOrMore,
----------------
davidxl wrote:
> wenlei wrote:
> > Set the default to true here so `partial-profile` alone can enable all related tweaks? 
> This should default to be true  since the partial profile is also used as a guard -- but perhaps as a follow up after more testing.
Ok, sounds good.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62540/new/

https://reviews.llvm.org/D62540