[PATCH] D79505: [mlir][StandardToLLVM] Add SinOp to LLVM dialect and lowering of std.sin to this op.

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar added a comment.



In D79505#2023280 <https://reviews.llvm.org/D79505#2023280>, @ftynse wrote:

> Could we have a test?


Tried to look for where to add test here. But couldnt find a test for say cos, , etc. Not sure what was the testing convention was. (I actually had a comment on the patch but as happens often, forgot to hit submit). I'll add a test anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79505/new/

https://reviews.llvm.org/D79505