[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 09:40:38 PDT 2020


scott.linder added a comment.

Thank you for the explanation; I'm also still lost as to why `.git/logs/HEAD` is referenced at all then. I would propose removing `find_first_existing_vc_file` entirely, as it seems to be completely redundant if there is another mechanism for ensuring the VCS header is up-to-date without triggering gratuitous rebuilds, but I will defer to any of the other reviewers on the `blame` for the scripts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79400/new/

https://reviews.llvm.org/D79400





More information about the llvm-commits mailing list