[PATCH] D78614: [AssumeBuilder] Add assume-simplify pass

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Is there a reason we do not have the simplification pass in the old PM?

Can you add the pass in the pipeline (somewhere) after the ones that create assumes? Maybe use `EnableKnowledgeRetention` in the pass pipeline to only schedule this pass if it is enabled so there is really no impact otherwise.

Otherwise this looks already fine to me.



================
Comment at: llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp:423
+
+  AS.dropRedundantKnowledge();
+  AS.RunCleanup(false);
----------------
Please add a comment here to explain the order in which things a run.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78614/new/

https://reviews.llvm.org/D78614