[PATCH] D79476: [AMDGPU] Don't implement GCNHazardRecognizer::PreEmitNoops(SUnit *)

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 08:35:30 PDT 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp:232
-unsigned GCNHazardRecognizer::PreEmitNoops(SUnit *SU) {
-  IsHazardRecognizerMode = false;
-  return PreEmitNoopsCommon(SU->getInstr());
----------------
Do we still need this variable? I am not sure, it is initialized as false, but is there an alive path after this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79476/new/

https://reviews.llvm.org/D79476





More information about the llvm-commits mailing list