[PATCH] D78623: [flang] Semantic checks for SELECT RANK

[Tim Keith via Phabricator via llvm-commits]

tskeith added a comment.

Please mark comments as done when you have done something in response, and indicate what you did if it's not obvious.



================
Comment at: flang/include/flang/Evaluate/shape.h:131
   static Result Scalar() { return Shape{}; }
-
+  Shape ReturnShape(int rank, NamedEntity &base) const {
+    Shape shape;
----------------
How about `CreateShape`?


================
Comment at: flang/lib/Semantics/check-select-rank.cpp:114
+                            "Same rank value (%s) not allowed more than once"_err_en_US,
+                            expr->AsFortran())
+                        .Attach(prevloc, "Previous use"_err_en_US);
----------------
Can you print `*val` instead of fetching and formatting expr?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78623/new/

https://reviews.llvm.org/D78623