[PATCH] D79452: [VectorCombine] scalarize binop of inserted elements into undef

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 06:57:47 PDT 2020


spatel updated this revision to Diff 262367.
spatel marked 4 inline comments as done.
spatel added a comment.

Patch updated - no logic changes but:

1. Added code comment to make cost metric explicit - scalarize unless original vector code is cheaper.
2. Added/retained value names to improve debugging experience (tests regenerated to show diffs).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79452/new/

https://reviews.llvm.org/D79452

Files:
  llvm/lib/Transforms/Vectorize/VectorCombine.cpp
  llvm/test/Transforms/VectorCombine/X86/insert-binop.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79452.262367.patch
Type: text/x-patch
Size: 5214 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200506/d14d6ff5/attachment.bin>


More information about the llvm-commits mailing list