[PATCH] D78708: [ARM] Extract from a VDUP

[Dave Green via Phabricator via llvm-commits]

dmgreen marked an inline comment as done.
dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:13279
+    SDValue X = Op0->getOperand(0);
+    if (VT == MVT::f16 && X.getValueType() == MVT::i32)
+      return DCI.DAG.getNode(ARMISD::VMOVhr, dl, VT, X);
----------------
samparker wrote:
> And other small types have already been promoted at this point?
Yeah. A VMOVhr will need to be between an i32 and an f16, which is why these are specially checked. Smaller types could theoretically be handled by the code below, but we wouldn't ever generate a ARMISD::VDUP with illegal arguments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78708/new/

https://reviews.llvm.org/D78708