[PATCH] D79435: [AMDGPU] Drop 16 bit subreg suffixes on print

Wed May 6 02:07:15 PDT 2020

vpykhtin accepted this revision.
vpykhtin added a comment.
This revision is now accepted and ready to land.

LGTM.

================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp:29-33
+static cl::opt<bool> Keep16BitSuffixes(
+  "amdgpu-keep-16-bit-reg-suffixes",
+  cl::desc("Keep .l and .h suffixes in asm for debugging purposes"),
+  cl::init(false),
+  cl::ReallyHidden);
----------------
rampitec wrote:
> rampitec wrote:
> > arsenm wrote:
> > > Could this be implemented as an assembler variant (e.g. AT&T vs. intel syntax?)
> > Probably. I did not explore this.
> Actually it looks like an overkill. x86 has created a separate InstPrinter as dialects are quite different. Here the difference is really minimal, I doubt it worth it.
Is there AbsolutelyHidden attrubute?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79435/new/

https://reviews.llvm.org/D79435