[PATCH] D62540: [SampleFDO] For functions without profiles, provide an option to put them in a special text section

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 19:26:10 PDT 2020


wenlei added a comment.

Now that the use case is for partial profile, I think an umbrella switch to tell whether input profile is a partial profile would be helpful. That'd be complimentary to the partial flag in the profile itself, because whether a profile is partial actually depends on the use case too, e.g. a profile from service A would be a partial profile for server B, but not partial for A itself.

We could then tie all optimization tweaks for partial profile to that switch (and the partial flag from profile itself), which makes it easier to use. If we want the flexibility for individual tuning, we could have specific flags like this one as narrower override for the umbrella switch. What do you think?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62540/new/

https://reviews.llvm.org/D62540





More information about the llvm-commits mailing list