[PATCH] D79454: [IR] `byval` arguments cause reads at call sites

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 17:17:21 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/IR/Instruction.cpp:542
+    return !cast<CallBase>(this)->doesNotReadMemory() ||
+           cast<CallBase>(this)->hasByValArgument();
   case Instruction::Store:
----------------
It technically reads memory, but does it really read memory from an IR perspective? This isn't supposed to be a program visible read?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79454/new/

https://reviews.llvm.org/D79454





More information about the llvm-commits mailing list