[PATCH] D79371: [ELF] Add convenience TableGen classes to enforce two dashes for options not supported by GNU ld

Tue May 5 16:12:51 PDT 2020

MaskRay marked an inline comment as done.
MaskRay added a comment.

In D79371#2020539 <https://reviews.llvm.org/D79371#2020539>, @tejohnson wrote:

> Since this is a lot of options that in some cases may have been used for some time (e.g. many the -thinlto-* ones have been supported for a few years now), it might be worth an announcement on llvm-dev so no one is surprised that their build scripts need updating.

(I did not the history of -thinlto-* but I can't find them referenced, probably because -plugin-opt=thinlto-* is the more common use case as gold only accepts -plugin-opt=*)

Created https://lists.llvm.org/pipermail/llvm-dev/2020-May/141416.html

================
Comment at: lld/ELF/Options.td:537
   HelpText<"Path to ThinLTO cached object file directory">;
 defm thinlto_cache_policy: Eq<"thinlto-cache-policy", "Pruning policy for the ThinLTO cache">;
+def thinlto_emit_imports_files: FF<"thinlto-emit-imports-files">;
----------------
tejohnson wrote:
> What about this one, looks like Eq takes both dash forms.
I left this one because I don't have a good name for it. EqEq?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79371/new/

https://reviews.llvm.org/D79371