[PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

[Amy Huang via Phabricator via llvm-commits]

akhuang added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3125-3126
   } else {
     // FIXME: Currently this only emits the global variables in the IR metadata.
     // This should also emit enums and static data members.
     const DIExpression *DIE = CVGV.GVInfo.get<const DIExpression *>();
----------------
rnk wrote:
> @akhuang, can we remove this FIXME? I think we addressed this simply by changing clang to emit this metadata.
Yep- thanks for catching that!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79447/new/

https://reviews.llvm.org/D79447