[PATCH] D79390: [Support] Sink LLD's parallel algorithm wrappers to support

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 15:40:41 PDT 2020


rnk marked 2 inline comments as done.
rnk added a comment.

Thanks!



================
Comment at: llvm/unittests/Support/ParallelTest.cpp:33
 
-  sort(parallel::par, std::begin(array), std::end(array));
+  parallelSort(std::begin(array), std::end(array));
   ASSERT_TRUE(llvm::is_sorted(array));
----------------
aganea wrote:
> `parallelSort(array)`?
The compiler didn't like that one:
```
llvm-project/llvm/unittests/Support/ParallelTest.cpp:33:3: error: no matching function for call to 'parallelSort'
  parallelSort(array);
  ^~~~~~~~~~~~
llvm-project/llvm/include/llvm/Support/Parallel.h:204:6: note: candidate template ignored: substitution failure [with RangeTy = unsigned int (&)[1048576]]: reference to type 'unsigned int [1048576]' requires an initializer
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79390/new/

https://reviews.llvm.org/D79390





More information about the llvm-commits mailing list