[PATCH] D79398: [WIP][dsymutil] Add reproducers to dsymutil

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 10:46:49 PDT 2020


aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/Options.td:157
 
+def gen_reproducer: F<"gen-reproducer">,
+  HelpText<"Generate a reproducer consisting of the input object files.">,
----------------
is there a reason why this isn't called `--generate-reproducer`? People are not going to call this very often (I hope!) so we should optimize for legibility?


================
Comment at: llvm/tools/dsymutil/Options.td:161
+
+def use_reproducer: Separate<["--", "-"], "use-reproducer">,
+  MetaVarName<"<path>">,
----------------
What about `--record-reproducer` and `--replay-reproducer`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79398/new/

https://reviews.llvm.org/D79398





More information about the llvm-commits mailing list