[PATCH] D72749: [PowerPC] Add exception constraint to FP sqrt, fma, min/max

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 09:08:35 PDT 2020


kpn added a comment.

Most of this is in TableGen files, and I have so little experience there that I can't review. I'm sorry.

The test cases have large changes in the generated assembly, but I can't read PowerPC assembly so I don't know what's going on there.

Is there a PowerPC person who can review meaningfully?



================
Comment at: llvm/test/CodeGen/PowerPC/fp-strict-fma-f128.ll:1
+; RUN: llc -verify-machineinstrs -ppc-asm-full-reg-names -ppc-vsr-nums-as-vr < %s -mtriple=powerpc64le-unknown-linux -mcpu=pwr9 -enable-ppc-quad-precision=true | FileCheck %s
+
----------------
amyk wrote:
> Exceeding 80 characters.
I don't think we care about test cases exceeding 80 characters. A quick check shows thousands with just RUN: lines longer than 80.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72749/new/

https://reviews.llvm.org/D72749





More information about the llvm-commits mailing list