[PATCH] D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 08:03:33 PDT 2020


epastor added a comment.

In D75306#2018313 <https://reviews.llvm.org/D75306#2018313>, @thakis wrote:

> Sorry it took a while. This is a good chunk of work, thanks for doing it. Smaller changes are faster to review :)
>
> As a general point, before sending out a change I'd suggest doing a detailed read by yourself to find things like typos in comments, notice things like needless duplication (sometimes, it's the right tradeoff), etc.


With apologies... I did do a detailed read. I didn't spot the things you did. I suppose that's what review is for, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75306/new/

https://reviews.llvm.org/D75306





More information about the llvm-commits mailing list