[PATCH] D76997: Fix StringRef::strLen in windows with clang++ C++17

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 08:03:30 PDT 2020


aaron.ballman added reviewers: aaron.ballman, dblaikie, rnk, majnemer, zturner.
aaron.ballman added a comment.

I looked at the definition available in MSVC 2017 (15.9) and it does have constexpr support, but it requires setting the conformance mode to properly honor `__cplusplus`. If you set `/Zc:__cplusplus`, I believe this code should work. Have you given that a shot?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76997/new/

https://reviews.llvm.org/D76997





More information about the llvm-commits mailing list