[PATCH] D79399: [CodeGen] Fix incorrect uses of getVectorNumElements()

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 03:11:59 PDT 2020


david-arm marked an inline comment as done.
david-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-ext-trunc.ll:1
+; REQUIRES: asserts
+; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve < %s | FileCheck %s
----------------
sdesmalen wrote:
> You can drop `REQUIRES: asserts` since this test is equally valid without asserts.
OK, I thought that since I was trying to test the actual code change (within an assert) that the test would only exercise that code path with asserts on. You are right though that it's equally valid without the assert, which is then just testing the codegen is correct. I assume buildbot builds and tests with asserts anyway?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79399/new/

https://reviews.llvm.org/D79399





More information about the llvm-commits mailing list