[PATCH] D79392: [SanitizerCoverage] Replace the unconditional store with a load, then a conditional store.

[Pratyai Mazumder via Phabricator via llvm-commits]

pratyai marked an inline comment as done.
pratyai added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:951
+    IRBuilder<> ThenIRB(ThenTerm);
+    auto Store = ThenIRB.CreateStore(ConstantInt::getTrue(Int1Ty), FlagPtr);
+    SetNoSanitizeMetadata(Load);
----------------
vitalybuka wrote:
> vitalybuka wrote:
> > This should be the opposite?
> > I'll fix this.
> Now:
> 
> ```
> if (Load) {
>   Store
> }
> ```
> 
> should be :
> 
> ```
> if (!Load) {
>   Store
> }
> ```
My bad; fixing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79392/new/

https://reviews.llvm.org/D79392