[PATCH] D79339: [llvm-objcopy][ELF] Allow --dump-section to dump an empty non-SHT_NOBITS section

Tue May 5 00:29:44 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.

================
Comment at: llvm/test/tools/llvm-objcopy/ELF/dump-section.test:51
+
+# EMPTY: 0
----------------
Nit: the prevailing pattern for FileCheck directives in this file is currently `#CHECK:` (no space). I'm okay if you want to change the other lines to match the `# CHECK:` style, but perhaps do as a separate NFC commit. Alternatively, make this match the existing ones.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79339/new/

https://reviews.llvm.org/D79339