[PATCH] D79211: [lld-macho] Support pc-relative section relocations

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:174
+        if (sectIdx >= sections.size())
+          fatal("Relocation section index is greater than number of sections");
+        r.target = sections[sectIdx];
----------------
MaskRay wrote:
> Error messages are usually not capitalized.
> 
> It'd be nice to have a test for zero r_symbolnum
Do you mean test as in unit test or an if-check? I don't think we can generate a zero r_symbolnum when for a non-extern relocation. I can check for it here though


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79211/new/

https://reviews.llvm.org/D79211