[PATCH] D79373: [mlir] Add FPToSIOp to Standard dialect.

[Han-Chung Wang via Phabricator via llvm-commits]

hanchung marked 2 inline comments as done.
hanchung added inline comments.


================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:1485
+  let description = [{
+    Cast from a value interpreted as floating-point to the corresponding
+    signed integer value. Similar to an element-wise `static_cast` in C++,
----------------
rriddle wrote:
> This is a little light on semantics, i.e., what is the rounding mode? towards zero? Can you beef this up? I would expect it to at least cover the same beats as the llvm equivalent:
> https://llvm.org/docs/LangRef.html#fptosi-to-instruction
I was referring it in the later sentence, but it would be great to point it out directly. Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79373/new/

https://reviews.llvm.org/D79373