[PATCH] D78164: [lit] Provide extension API for custom result categories

Mon May 4 13:26:59 PDT 2020

yln marked an inline comment as done.
yln added inline comments.

================
Comment at: llvm/utils/lit/tests/Inputs/custom-result-category/lit.cfg:8
+config.suffixes = ['.txt']
+config.test_format = format.MyFormat()
+config.test_source_root = None
----------------
abhinavgaba wrote:
> Using MyFormat() here is causing `check-lit` to hang indefinitely on WIndows x86-64 (Python 2.7.6).
> 
> Changing this to use `config.test_format = lit.format/ShTest()`  "fixes" the hang (although then the test fails, which is expected).
> 
> Is that a known issue?
I disabled the test on Windows in 3610fd8c5c6039c096d61c376b37a724a81c4d35.  Would you be able to help me debug this? (I don't have access to a Windows machine.)

My best guess is that this has something to do with loading the class from the SITE_DIR:
```
import site
site.addsitedir(os.path.dirname(__file__))
```
https://github.com/llvm/llvm-project/blob/6cecd3c3dbef48eca6c4cf2dcc2df3290ab91488/llvm/utils/lit/tests/lit.cfg#L46
https://docs.python.org/3.9/library/site.html#site.USER_SITE

Can you also try Python3?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78164/new/

https://reviews.llvm.org/D78164