[PATCH] D79015: [PowerPC] Fix missing GOT indirect variant kind

Kamau Bridgeman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 11:49:06 PDT 2020


kamaub accepted this revision as: kamaub.
kamaub added a comment.
This revision is now accepted and ready to land.

This LGTM, one minor comment about test case explanation, it can be done pre-commit for sure.



================
Comment at: llvm/test/MC/PowerPC/future-reloc.s:5
+# RUN: llvm-readobj -r | FileCheck %s -check-prefix=READOBJ
+
+# MC-NOT:    error: invalid variant
----------------
Could you add a brief explanation of this test case here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79015/new/

https://reviews.llvm.org/D79015





More information about the llvm-commits mailing list