[PATCH] D79342: [flang] Fix cmake circular dependency error

[Tim Keith via Phabricator via llvm-commits]

tskeith created this revision.
tskeith added a project: Flang.
Herald added subscribers: llvm-commits, mgorny.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: DavidTruby.
Herald added a project: LLVM.
tskeith added reviewers: clementval, stephenneuendorffer.
tskeith added a comment.

@clementval, you added this dependency to fix a linking problem. If this change makes it come back, can you provide details? FortranEvaluate should not depend on FortranSemantics at link time.


The combination of these two changes lead to a cmake error in flang:

- https://reviews.llvm.org/D78340
- https://reviews.llvm.org/D79241

The error is:

  CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle):
    "FortranEvaluate" of type STATIC_LIBRARY
      depends on "FortranSemantics" (weak)
    "obj.FortranSemantics" of type OBJECT_LIBRARY
      depends on "FortranEvaluate" (strong)
    "FortranSemantics" of type STATIC_LIBRARY
      depends on "FortranEvaluate" (weak)
      depends on "obj.FortranSemantics" (strong)
  At least one of these targets is not a STATIC_LIBRARY.  Cyclic dependencies are allowed only among static libraries.

This change attempts to remove the link-time dependency of FortranEvaluate
on FortranSemantics.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79342

Files:
  flang/lib/Evaluate/CMakeLists.txt


Index: flang/lib/Evaluate/CMakeLists.txt
===================================================================
--- flang/lib/Evaluate/CMakeLists.txt
+++ flang/lib/Evaluate/CMakeLists.txt
@@ -29,7 +29,6 @@
   LINK_LIBS
   FortranCommon
   FortranDecimal
-  FortranSemantics
   FortranParser
 )
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79342.261873.patch
Type: text/x-patch
Size: 293 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200504/54948312/attachment-0001.bin>