[PATCH] D79332: [MLIR] Nested regions test for Buffer Assginment

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/test/Transforms/buffer-placement.mlir:416
+
+// Test Case: Nested regions
+
----------------
Can you expand the doc on what this test is doing? Either here or in line with the checks themselves.



================
Comment at: mlir/test/Transforms/buffer-placement.mlir:452
+// CHECK-NEXT: %[[GENERIC2_ALLOC:.*]] = alloc()
+// CHECK-NEXT: linalg.generic {{{.*}}} %[[ARG1]], %[[GENERIC2_ALLOC]]
+//      CHECK: dealloc %[[GENERIC2_ALLOC]]
----------------
Nit: can you indent it to represent the expected nesting? It'll make it more readable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79332/new/

https://reviews.llvm.org/D79332