[PATCH] D79127: [XCOFF][AIX] Emit correct alignment for csect

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 10:11:40 PDT 2020


jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:61
+  cast<MCSymbolXCOFF>(Symbol)->getRepresentedCsect()->setAlignment(
+      Align(ByteAlignment));
 
----------------
DiggerLin wrote:
> do we need to add safeguard of   cast<MCSymbolXCOFF>(Symbol)->hasRepresentedCsect() here ?
No, common symbol must be a csect, so it should have represented csect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79127/new/

https://reviews.llvm.org/D79127





More information about the llvm-commits mailing list