[PATCH] D79220: [XCOFF] XCOFF constants, MCObjectFileInfo placeholder code for DWARF; NFC

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 09:37:57 PDT 2020


hubert.reinterpretcast marked 2 inline comments as done.
hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:841
+  // TODO: Populate the DWARF sections appropriately.
+  DwarfAbbrevSection = nullptr;   // SSUBTYP_DWABREV
+  DwarfInfoSection = nullptr;     // SSUBTYP_DWINFO
----------------
DiggerLin wrote:
> what about to the initiation in the MCObjectFileInfo.h ?
> 
> as 
> MCSection *DwarfAbbrevSection = = nullptr;
That's the common default that this code is supposed to eventually override. The patch description already says this patch is NFC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79220/new/

https://reviews.llvm.org/D79220





More information about the llvm-commits mailing list