[PATCH] D79324: [WebAssembly] Fix block marker placing after fixUnwindMismatches

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 05:50:07 PDT 2020


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp:1241
+  if (AppendixBB)
+    BrDests.push_back(AppendixBB);
+
----------------
aheejin wrote:
> Fix for bug 3
Before we add all branch dests in `BrDestToTryRanges` to `BrDests` so that `block`/`end` markers are placed for them, but actually we don't need the marker for non-appendix BB, because there is already an existing `try`/`end` pair that can serve the same purpose. Please refer to the CL description for bugfix 3.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79324/new/

https://reviews.llvm.org/D79324





More information about the llvm-commits mailing list