[PATCH] D79275: [llvm][NFC] Inliner: factor cost and reporting out of inlining process

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 3 10:37:29 PDT 2020


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good to me (I'd probably have pulled it out into a separate function in one go (as it stands the code feels awkwardly complicated - creating a lambda for just one caller - I generally try to make the code self-consistent/justified with each commit, insofar as that's possible) but given you're headed that way, whichever way you find best to get there seems OK)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79275/new/

https://reviews.llvm.org/D79275





More information about the llvm-commits mailing list