[lld] d735c70 - [test] Fix lld's ELF/linkerscript/thunk-gen-mips.s

Thomas Preud'homme via llvm-commits llvm-commits at lists.llvm.org
Sat May 2 15:04:09 PDT 2020


Author: Thomas Preud'homme
Date: 2020-05-02T22:49:23+01:00
New Revision: d735c7048c6ce841546b5757632aff793d4a0851

URL: https://github.com/llvm/llvm-project/commit/d735c7048c6ce841546b5757632aff793d4a0851
DIFF: https://github.com/llvm/llvm-project/commit/d735c7048c6ce841546b5757632aff793d4a0851.diff

LOG: [test] Fix lld's ELF/linkerscript/thunk-gen-mips.s

Summary:
Lld test ELF/linkerscript/thunk-gen-mips.s was accidentally disabled due
to the use of wrong FileCheck directives. As a result the test seems to
have bitrotted as it fails to pass if fixing the directive. To ease
updates to the test in case of change of the __start address the checks
have been changed to use numeric variables to express all the addresses
based on the __start address.

Reviewed By: atanasyan

Differential Revision: https://reviews.llvm.org/D79270

Added: 
    

Modified: 
    lld/test/ELF/linkerscript/thunk-gen-mips.s

Removed: 
    


################################################################################
diff  --git a/lld/test/ELF/linkerscript/thunk-gen-mips.s b/lld/test/ELF/linkerscript/thunk-gen-mips.s
index 3b7ea02176bb..aa74164b1568 100644
--- a/lld/test/ELF/linkerscript/thunk-gen-mips.s
+++ b/lld/test/ELF/linkerscript/thunk-gen-mips.s
@@ -15,9 +15,9 @@
 # RUN: ld.lld -o %t.exe --script %t.script %t %t1
 # RUN: llvm-objdump -t %t.exe | FileCheck %s
 # CHECK: SYMBOL TABLE:
-# CHECK-ANY: 00000000         .text           00000000 _start
-# CHECK-ANY: 0010000c l     F .text           00000010 __LA25Thunk_too_far
-# CHECK-ANY: 00100020 g     F .text           00000024 too_far
+# CHECK-DAG:                         [[#%x, START_ADDR:]] g       .text           00000000 _start
+# CHECK-DAG: {{0*}}[[#THUNK_ADDR:START_ADDR+0x100000+12]] l     F .text           00000010 __LA25Thunk_too_far
+# CHECK-DAG:                     {{0*}}[[#THUNK_ADDR+20]] g     F .text           0000000c too_far
 
 .ifdef MAIN
 .global _start


        


More information about the llvm-commits mailing list