[PATCH] D79266: [mlir] Add a new context flag for disabling/enabling multi-threading

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 2 12:42:52 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/docs/PassManagement.md:804
 ```shell
-$ mlir-opt foo.mlir -disable-pass-threading -pass-pipeline='func(cse,canonicalize)' -convert-std-to-llvm -pass-timing -pass-timing-display=list
+$ mlir-opt foo.mlir -mlir-disable-threading -pass-pipeline='func(cse,canonicalize)' -convert-std-to-llvm -pass-timing -pass-timing-display=list
 
----------------
lattner wrote:
> Bikeshed: I'm not sure the precedence on this, I think that "-disable-mlir-threading" would read better and be more discoverable than "-mlir-disable-threading".
It's consistent with the other flags we have in IR/. I started doing that a while ago to make it easier to find flags that only relate to MLIR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79266/new/

https://reviews.llvm.org/D79266





More information about the llvm-commits mailing list