[PATCH] D79286: [ELF] Move SHF_LINK_ORDER till OutputSection addresses are known

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

This LGTM. Please wait for another approvement.

nit: the patch is missing content.

(I am on vacation until 12 of May).



================
Comment at: lld/ELF/Writer.cpp:2135
+  // finalizeAddressDependentContent may have added local symbols to the static
+  // symbol table.
   finalizeSynthetic(in.symTab);
----------------
nit: unrelated comment change.


================
Comment at: lld/test/ELF/linkorder-script.s:11
+// RUN: ld.lld --script %t.script %t.o -o %t
+// RUN: llvm-readobj -x .linkorder  %t | FileCheck %s
+
----------------
nit: double space after `.linkorder`


================
Comment at: lld/test/ELF/linkorder-script.s:23
+_start:
+.quad 0
+
----------------
nit: I'd probably just use `nop` for `text*`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79286/new/

https://reviews.llvm.org/D79286