[PATCH] D78434: [mlir] resolve types from attributes in assemblyFormat

[Martin Waitz via Phabricator via llvm-commits]

tali marked an inline comment as done.
tali added inline comments.


================
Comment at: mlir/test/mlir-tblgen/op-format.mlir:106
+// CHECK: test.format_all_types_match_attr 1 : i64, %[[I64]]
+%ignored_res2 = test.format_all_types_match_attr 1 : i64, %i64
+
----------------
I would really like to be able to format this example as `test.format_all_types_match_attr 1, %i64 : i64`, with the type at the end.
We could add support for `type($attribute)`, and suppress printing of the attribute type if it is specified explicitly or when it can be inferred.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78434/new/

https://reviews.llvm.org/D78434