[PATCH] D79262: [COFF] Add and use a zero-copy tokenizer for .drectve

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Nice!

I don't believe the time improvement unless more data is collected, but this is still a very nice win :)

How involved would it be to move all callers to this new style api (posix too, I suppose)?



================
Comment at: llvm/lib/Support/CommandLine.cpp:973
+      if (isWhitespaceOrNull(Src[I])) {
+        AddToken(Saver.save(Token.str()));
         Token.clear();
----------------
nit: Maybe add a comment along the lines of "// The token required unquoting, so it must always be save, regardless of AlwaysCopy".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79262/new/

https://reviews.llvm.org/D79262