[PATCH] D79271: [mlir][Linalg] Mostly NFC - Refactor Linalg patterns and transformations.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 17:18:02 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h:92
+/// Linalg tiling patterns.
+///
+struct LinalgBaseTilingPattern : public RewritePattern {
----------------
These patterns seem light on documentation, can you add some?


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp:139
+  return res.getDefiningOp();
+  ;
+}
----------------
Extraneous semicolon



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79271/new/

https://reviews.llvm.org/D79271





More information about the llvm-commits mailing list