[PATCH] D79005: [LLD][COFF] Move debug info for thread-local variables into PDB global stream

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: lld/COFF/PDB.cpp:808
   case SymbolKind::S_UDT:
     return !isGlobalScope;
   // S_GDATA32 does not go in the module stream, but S_LDATA32 does.
----------------
rnk wrote:
> Looks like we need to send S_LDATA32 to here.
Not exactly. `S_LDATA32` always remains in the module stream, but is duplicated into the globals stream only if it's a global.


================
Comment at: lld/COFF/PDB.cpp:809
     return !isGlobalScope;
   // S_GDATA32 does not go in the module stream, but S_LDATA32 does.
   case SymbolKind::S_LDATA32:
----------------
rnk wrote:
> S_LTHREAD32 doesn't follow this pattern? I was kind of expecting it to show up wherever S_LDATA32 is.
It is indeed following the same pattern!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79005/new/

https://reviews.llvm.org/D79005