[PATCH] D79138: [Inlining] Teach shouldBeDeferred to take the total cost into account

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 17:17:18 PDT 2020


davidxl added a comment.

This is a conceptually a very good change. I think it should be split into two stages. The first is to make the changes but with default settings as NFC. The second stage is to reset the parameter with some benchmark number (e.g, spec perf should not regress, also code size impact).

One way to to the first stage is to not consider NumCaller adjustment if the deferral scale is a special value (such as -1).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79138/new/

https://reviews.llvm.org/D79138





More information about the llvm-commits mailing list