[PATCH] D78494: [AMDGPU][CODEGEN] Added 'A' constraint for inline assembler

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 17:16:11 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1319
+      return false;
+    } else { // A literal
+      O << Val;
----------------
No else after return


================
Comment at: llvm/test/CodeGen/AMDGPU/inline-constraints.ll:299
+  ret i32 %v0
+}
----------------
can you also add some tests for packed <2 x i16>/<2 x half> operands


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78494/new/

https://reviews.llvm.org/D78494





More information about the llvm-commits mailing list