[PATCH] D79240: [MLIR] Move Verifier and Dominance Analysis from /Analysis to /IR

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer created this revision.
Herald added subscribers: llvm-commits, Kayjukh, frgossen, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini, mgorny.
Herald added a reviewer: rriddle.
Herald added a project: LLVM.
stephenneuendorffer added a child revision: D79241: [cmake] Ensure that LINK_LIBS are dependencies for object library targets.
rriddle requested changes to this revision.
rriddle added a comment.
This revision now requires changes to proceed.
stephenneuendorffer updated this revision to Diff 261501.
stephenneuendorffer updated this revision to Diff 261539.
Herald added a reviewer: nicolasvasilache.

The files are marked as being added, but I would have expected something to mark the original locations as being moved/deleted.



================
Comment at: mlir/examples/toy/Ch2/mlir/MLIRGen.cpp:18
 
-#include "mlir/Analysis/Verifier.h"
+#include "mlir/IR/Verifier.h"
 #include "mlir/IR/Attributes.h"
----------------
Can you fix these include orderings now? I would expect a run of clang-format to handle it.


================
Comment at: mlir/include/mlir/IR/Dominance.h:9
+
+#ifndef MLIR_ANALYSIS_DOMINANCE_H
+#define MLIR_ANALYSIS_DOMINANCE_H
----------------
MLIR_IR_ Now


================
Comment at: mlir/include/mlir/IR/Verifier.h:9
+
+#ifndef MLIR_ANALYSIS_VERIFIER_H
+#define MLIR_ANALYSIS_VERIFIER_H
----------------
MLIR_IR


These libraries are distinct from other things in Analysis in that they
operate only on core IR concepts.  This also simplifies dependencies
so that Dialect -> Analysis -> Parser -> IR.  Previously, the parser depended
on portions of the the Analysis directory as well, which sometimes
caused issues with the way the cmake makefile generator discovers
dependencies on generated files during compilation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79240

Files:
  mlir/examples/toy/Ch2/mlir/MLIRGen.cpp
  mlir/examples/toy/Ch2/toyc.cpp
  mlir/examples/toy/Ch3/mlir/MLIRGen.cpp
  mlir/examples/toy/Ch3/toyc.cpp
  mlir/examples/toy/Ch4/mlir/MLIRGen.cpp
  mlir/examples/toy/Ch4/toyc.cpp
  mlir/examples/toy/Ch5/mlir/MLIRGen.cpp
  mlir/examples/toy/Ch5/toyc.cpp
  mlir/examples/toy/Ch6/mlir/MLIRGen.cpp
  mlir/examples/toy/Ch6/toyc.cpp
  mlir/examples/toy/Ch7/mlir/MLIRGen.cpp
  mlir/examples/toy/Ch7/toyc.cpp
  mlir/include/mlir/Analysis/Dominance.h
  mlir/include/mlir/Analysis/Verifier.h
  mlir/include/mlir/IR/Dominance.h
  mlir/include/mlir/IR/Verifier.h
  mlir/include/mlir/Transforms/BufferPlacement.h
  mlir/lib/Analysis/CMakeLists.txt
  mlir/lib/Analysis/Dominance.cpp
  mlir/lib/Analysis/Verifier.cpp
  mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
  mlir/lib/IR/Dominance.cpp
  mlir/lib/IR/Verifier.cpp
  mlir/lib/Parser/CMakeLists.txt
  mlir/lib/Parser/Parser.cpp
  mlir/lib/Pass/Pass.cpp
  mlir/lib/Transforms/CSE.cpp
  mlir/lib/Transforms/MemRefDataFlowOpt.cpp
  mlir/lib/Transforms/Utils/Utils.cpp
  mlir/lib/Translation/Translation.cpp
  mlir/test/lib/Transforms/TestDominance.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79240.261539.patch
Type: text/x-patch
Size: 14606 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200502/8e61578b/attachment-0001.bin>